search

babashka / sci.configs

A collection of ready to be used SCI configs
https://babashka.org/sci.configs/
Other
20 stars 18 forks source link

WIP: promesa: add `done?` #16

Closed avelino closed 1 year ago

avelino commented 1 year ago

could not resolve symbol: p/done? it is in the documentation that this "method" exists https://github.com/babashka/nbb/blob/main/doc/api.md#promesacore

borkdude commented 1 year ago

This doesn't exist for CLJS anymore, since you can't inspect the state of a promise in CLJS.

avelino commented 1 year ago

oops, sorry why don't you let the tests run automatically?

borkdude commented 1 year ago

What do you mean? They are run automatically.

Screenshot 2022-11-24 at 14 01 48

Maybe I should ask you: why don't you run the tests locally first, before making a PR ;)

avelino commented 1 year ago

@borkdude did not run after this commit: https://github.com/babashka/sci.configs/pull/16/commits/c72c7bf022eacd481ef3b273fe65b65fc7af40f1

borkdude commented 1 year ago

It did?

Screenshot 2022-11-24 at 15 11 29
borkdude commented 1 year ago

You can also see that here https://github.com/babashka/sci.configs/actions/runs/3540775251/jobs/5944233179

avelino commented 1 year ago 
 :cause Unable to resolve var: done? in this context at line 175 /home/runner/work/sci.configs/sci.configs/src/sci/configs/funcool/promesa.cljs

done? change to p/done? in this commit

borkdude commented 1 year ago

Yes.... and when you go to the red cross sign, you will see that the tests still failed.

Screenshot 2022-11-24 at 15 23 22