babashka / sci.configs

A collection of ready to be used SCI configs
https://babashka.org/sci.configs/
Other
19 stars 17 forks source link

Add clojure.core #20

Closed Oddsor closed 12 months ago

Oddsor commented 12 months ago

Add new namespace that includes new functions added to clojure.core in version 1.11.

Also add tests verifying that functions are properly included.

Oddsor commented 12 months ago

Continuation on this issue reported for Jet: https://github.com/borkdude/jet/issues/137

borkdude commented 12 months ago

Thanks. My proposal would be to split up clojure 1.11 into a separate namespace so you can load the namespaces you wish to use based on the clojure version you're allowed to use. If we stuff 1.12 stuff in there as well, but you're forced to use 1.11 you can't use the extras namespace anymore. Does that make sense?

Oddsor commented 12 months ago

Yes, that makes sense! What would be a decent naming scheme? clojure.core.1-11 or clojure.core-1-11? 🤔

borkdude commented 12 months ago

I'd say clojure-1-11

Oddsor commented 12 months ago

I also changed the namespace's "api" back to namespaces, as it might make sense to expand that definition to include clojure.math as well eventually? https://clojure.github.io/clojure/#clojure.math

borkdude commented 12 months ago

Thanks!