search

babashka / sci.configs

A collection of ready to be used SCI configs
https://babashka.org/sci.configs/
Other
19 stars 17 forks source link

re-frame.core/dispatch-sync #25

Closed awb99 closed 10 months ago

awb99 commented 10 months ago

I am using re-frame inside sci and I add the ns-bindings via sci.configs. I noticed that re-frame.core/dispatch-sync is not available in the namespace. This is really weird, since re-frame.core/dispatch is available. Could it be that the copy-ns implementation has a problem when the function-name contains a "-" inside? Or perhaps "sync" is somehow reserved/special and therefore does not get included?

What is weirder is that inside my app I sometimes used dispatch-sync; so it is inside the bundle. Just the sci namespace does not have it.

I will investigate more into this myself, as I guess it more likely is an error inside my app.

Regards

borkdude commented 10 months ago

The tests include a reference to dispatch-sync as you can see here: https://github.com/babashka/sci.configs/blob/main/test/re_frame/re_frame_test.cljs and they run successfully on CI.

awb99 commented 10 months ago

My mistake! Just found out that my old non-sci-configs config was overriding this namespace. Sorry.

awb99 commented 10 months ago

many thanks!

awb99 commented 10 months ago

closed.