search

babashka / sci.configs

A collection of ready to be used SCI configs
https://babashka.org/sci.configs/
Other
19 stars 17 forks source link

WIP Copy over clojure.test implementation from nbb #7

Closed PEZ closed 2 years ago

PEZ commented 2 years ago

Fixing #6

I've copied over things as they were implemented in nbb and improvised a bit around things I didn't know how to do.

One such thing I don't know how to do is where the nbb clojure.test implementation uses the nbb ctx, such as here:

https://github.com/PEZ/sci.configs/blob/6f4bfe2e43fbde08b064f079c6e39e009beb3b38/src/sci/configs/impl/clojure/test.cljs#L480

I created a dummy sci.configs.core namespace and placed an atom there, but this is of course not the context that is needed. In the case of Joyride we need joyride.sci's context, right?

In any case when I try to use things from clojure.test in a Joyride script I get:

ERROR: Run Workspace Script... Failed: test/ignore_form_test.cljs Cannot read properties of null (reading 'get')

Which I think might be because of this ctx atom not being populated as it should. (And it could be some completely other things I've done wrong, of course.)

borkdude commented 2 years ago

@PEZ I have looked at this on the train, but probably won't get to it before I'm back from clojureD - see you soon!

borkdude commented 2 years ago

@PEZ I added the cljs.test config now