search

babbleberry / rpi4-osdev

Tutorial: Writing a "bare metal" operating system for Raspberry Pi 4
https://www.rpi4os.com
Creative Commons Zero v1.0 Universal
3.37k stars 246 forks source link

Pull Up Pull down register is the wrong way around #50

Closed LabNelson closed 3 months ago

LabNelson commented 3 months ago

The enum in io.c (part14-spi-ethernet) of pull up pull down register is the wrong way around. Current implementation: enum { Pull_None = 0, Pull_Down = 1, // Are down and up the right way around? Pull_Up = 2 }; Correct implementation: enum { Pull_None = 0, Pull_Down = 2, Pull_Up = 1 }; source:

GPIO-PUllUpDown_Register_RPi4

page 74 of bcm2711 ARM Peripherals

LabNelson commented 3 months ago

Will be solved by pullrequest #51