search

babbush / HistoricalFermiLib

This is repo where we developed FermiLib, which then became OpenFermion
Apache License 2.0
1 stars 0 forks source link

Nqubits #27

Closed Spaceenter closed 7 years ago

Spaceenter commented 7 years ago

One left-over is the demo. There is some small issue with ipython notebook on my laptop, will fix the demo in a follow up CL.

wsws-macbookpro:src wsws$ cat precommit_tests python -m unittest discover -p "test.py" pep8 .py --ignore=E111,E114,E226

wsws-macbookpro:src wsws$ ./precommit_tests .......................................................................................................................................................................................................................................................................................................................................................................................................................

Ran 407 tests in 24.197s

OK

babbush commented 7 years ago

All looks good to me. Pretty straightforward changes, just what we talked about. Thanks Wei!

Spaceenter commented 7 years ago

It seems like this is not merged "Closed with unmerged commits"

babbush commented 7 years ago

Oh, not sure what happened there. I am playing around with the code now. It looks great. One comment though which I somehow missed in the code review is that I'm not sure I like that the string method now prints out a "+" sign when the coefficient is positive. That's a one line change though.

I guess also this shouldn't have been closed because the QubitTerm initializer stuff is left.

Thanks again for all your help Wei!

On Mon, Mar 20, 2017 at 6:34 PM, Wei Sun notifications@github.com wrote:

Merged #27 https://github.com/babbush/fermilib/pull/27.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/babbush/fermilib/pull/27#event-1007791651, or mute the thread https://github.com/notifications/unsubscribe-auth/ANlTf1yMtji3-AoIuRwj1nGghF5OmhpQks5rnykJgaJpZM4MjNaH .