Fix timeout value on reader thread wait in SMS send example

babca / python-gsmmodem

Maintained fork of a Python module to control GSM modems attached to the system: send/receive SMS messages in your scripts, handle calls, and more.

GNU Lesser General Public License v3.0

174 stars 106 forks source link

Fix timeout value on reader thread wait in SMS send example #77

Open devegied opened 5 years ago

devegied commented 5 years ago

timeout value of 2**31 in join was returning immediately on Raspberry Pi

coveralls commented 5 years ago

Coverage remained the same at 89.804% when pulling c7a476b7539586f80c0eda4def685bcc3203c2e4 on devegied:master into 5c816bae121c552850e88238da15344fd299bb0e on babca:master.

coveralls commented 5 years ago

Coverage increased (+0.01%) to 89.814% when pulling fe890cade6069bb378abe85a5d8416986df29813 on devegied:master into 5c816bae121c552850e88238da15344fd299bb0e on babca:master.

mmmcorpsvit commented 5 years ago

in MS windows too return on default value where depend from OS this value ? this constant?

lcnittl commented 2 years ago

I believe that a newer release of threading treats numbers bigger than 2**29 (have not tested everything between, but 2**30 does this already) like a 0 timeout. Maybe some number conversion somewhere deeper that results in a negative number? In any case this should be safe to be removed, as the deafult timeout=None waits indefinitely.