search

babel / babel-eslint

:tokyo_tower: A wrapper for Babel's parser used for ESLint (renamed to @babel/eslint-parser)
https://github.com/babel/babel/tree/main/eslint/babel-eslint-parser
MIT License
2.96k stars 208 forks source link

Add failing test for `classPrivateMethods` (regression) #776

Closed mrtnzlml closed 4 years ago

mrtnzlml commented 5 years ago

Hi, I read this PR https://github.com/babel/babel-eslint/pull/729 and this issue https://github.com/babel/babel-eslint/issues/728 and it seems like classPrivateMethods should work. However, it doesn't. So I added a failing test since I don't know how to fix it.

Thank you very much for checking it.

anthonator commented 5 years ago

Is there a workaround for this until this is fixed?

justintime4tea commented 5 years ago

Below is relevant for 10.0.3 apparently (and near that version? it's latest available on NPM...)

I don't know what the current issue is but if someone find this and is using an older (latest?) version like me then the below is what silenced my warning/error about it:

node_modules/babel-eslint/lib/parse.js Right around line 21 is an array Plugins Add "classPrivateMethods" to that list.

In newer code it looks like you should be able to pass something in. Haven't tried it but I'm not going to fill my projects with node dependencies from Git (other than our private repos that we must).

omerdn1 commented 4 years ago

This issue is fixed in #801. Hoping this gets merged soon.

kaicataldo commented 4 years ago

Thank you for the PR. Now that @babel/eslint-parser has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.