search

babel / babel-eslint

:tokyo_tower: A wrapper for Babel's parser used for ESLint (renamed to @babel/eslint-parser)
https://github.com/babel/babel/tree/main/eslint/babel-eslint-parser
MIT License
2.96k stars 208 forks source link

Release babel-eslint@11 #787

Closed kentcdodds closed 4 years ago

kentcdodds commented 5 years ago

I created a milestone for tracking the progress on this. I'm not certain whether I added all of the relevant PRs and issues though. I'm hoping that by tracking this we can get a better sense of what needs to happen and what blockers there are for this. I personally have been having a great experience with the alpha and would love to have an official release :)

mskelton commented 4 years ago

This issue was created 8 months ago and very little has happened since then. I too would like to see v11 get released, but with issues that are over a year old still pending, most would assume this project is dead and move on. Is there any plan to continue development on v11 and if not, where does that leave current users of babel-eslint?

existentialism commented 4 years ago

@mskelton curious, is there a specific issue you're needing fixed? is there something in 11.0.0-beta.2 that isn't working?

We absolutely plan on continuing development: we've already spent a bit of effort moving and consolidating all the babel/eslint-related packages into our monorepo, and are committed to supporting them all (keep in mind we're a small team of volunteers)!

EDIT: Let's add a note to the README that points to the Babel issue so others aren't worried as well?

kaicataldo commented 4 years ago

As @existentialism said, we've continued working on this project in the babel/babel repo (please see the relevant issue here if you want to follow along).

mskelton commented 4 years ago

Thanks for the info! I wasn't aware that this was being moved to the main repo. Thanks for all the work you do in maintaining Babel!

existentialism commented 4 years ago

👍 are you using v11 beta? We definitely want to make sure we fix any issues you (or others) are having!

mskelton commented 4 years ago

@existentialism No, the v11 beta is working well, I was just concerned if I needed to look for a different tool if this was no longer going to be maintained, but you answered that question, so I'm all good now 👍 Thanks again!

rjgotten commented 4 years ago

@existentialism Is there something in 11.0.0-beta.2 that isn't working?

Yes; there is actually.

Specifically https://github.com/babel/babel/issues/10904, which apparently might have been fixed in @babel/eslint-parser with https://github.com/babel/babel/pull/10828 but was either not back-ported to babel-eslint yet, or wasn't actually fixed.

Import expressions with template literals are the recommended pattern to implement lazy chunks with Webpack. ESLint itself still does not parse import expressions, meaning babel-eslint is a pre-requisite to lint files correctly.

You can work around the linter crash by fine tuning and selectively disabling a few linting rules with (fairly) minimal impact, so it isn't a complete show-stopper. But it's very, very ugly nonetheless.