search

babel / broccoli-babel-transpiler

Broccoli plugin for Babel
MIT License
57 stars 73 forks source link

.babelrc changes do not bust cache #153

Open oligriffiths opened 6 years ago

oligriffiths commented 6 years ago

When using a .babelrc (or similar) config file for babel, changes to this file to not bust the persistent cache, causing compiled outputs to not change.

Not sure the best way to handle this as https://babeljs.io/docs/en/config-files lists various techniques babel goes through to find config file, but it could be as simple as including their hash in the cache key.

rwjblue commented 6 years ago

Don’t we disable using babelrc files? That is certainly our intent (and definitely worked at one point).

oligriffiths commented 6 years ago

It worked in V6 of this plugin.

Why do we want to disable them? They’re pretty common in the js community.

On 5 Oct 2018, at 09:26, Robert Jackson notifications@github.com wrote:

Don’t we disable using babelrc files? That is certainly our intent (and definitely worked at one point).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

rwjblue commented 6 years ago

Ahh, ember-cli-babel disabled, not broccoli-babel-transpiler.

rwjblue commented 6 years ago

Should look into how https://babeljs.io/docs/en/config-files#apicache works internally in babel, see if we can leverage the same cache key that they use.

Turbo87 commented 6 years ago

to answer your question, ember-cli wants more control over the Babel plugins that get used by default, and using the babelrc file makes that more difficult which is why we disabled it there