search

babel / eslint-plugin-babel

An ESlint rule plugin companion to babel-eslint
https://github.com/babel/babel-eslint
Other
389 stars 62 forks source link

Add `no-dupe-class-members` rule with support for class properties #191

Closed Turbo87 closed 4 years ago

Turbo87 commented 4 years ago

This PR continues #173, but adds a bit of code to detect and ignore the common foo = this.foo.bind(this); pattern, that was mentioned in #190.

Resolves #190

/cc @ljharb

Turbo87 commented 4 years ago

@ljharb done, thanks for the quick review

Turbo87 commented 4 years ago

something about CI appears to be strange. opening TravisCI shows CI as "passed", but at GitHub it still shows as pending. not sure what to do about this 🤔

existentialism commented 4 years ago

@Turbo87 really our fault for not making this more obvious, but we're consolidating most of our eslint-related repos into the main monorepo (more info: https://github.com/babel/babel/issues/10752).

In anticipation of this, mind opening a PR for it over there? I can assist if you're too busy, sorry for the trouble.

Turbo87 commented 4 years ago

I'll have a look. thanks for the warning @existentialism :)

kaicataldo commented 4 years ago

Thank you for the PR. Now that @babel/eslint-plugin has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.