search

babel / minify

:scissors: An ES6+ aware minifier based on the Babel toolchain (beta)
https://babeljs.io/repl
MIT License
4.4k stars 225 forks source link

chore: Don't do shallow clones on travis #907

Closed pksunkara closed 6 years ago

pksunkara commented 6 years ago

Lerna canary doesn't work correctly with shallow clones.

From https://github.com/lerna/lerna/issues/1583#issuecomment-424596666.

@boopathi I can also incorporate #906 if you decide on it.

From #900

So, basically, once this PR is merged and you guys publish all the packages, the license issues will be fixed.

You haven't published all the packages. Only the packages which got changed, got published. Which means, the licensing issues still exist for older packages. Can you do a lerna publish --force-publish to fix this? (A new patch version should be good enough). Very important for us.

boopathi commented 6 years ago

Interesting. Does learn depend on git before publishing? why?

pksunkara commented 6 years ago

Canary releases depend on finding the distance from the recent tag so that they can be correctly versioned according to semver.

pksunkara commented 6 years ago

Fixed. Please don't forget to do a 0.5.1 release and publish all the packages. Some of them still don't have licenses in the distributed versions.

pksunkara commented 6 years ago

@boopathi Some of the packages like babel-plugin-minify-guarded-expressions still doesn't have licenses since you haven't published them with 0.5.0. Please fix this.

ajkl2533 commented 6 years ago

@boopathi Hi could you please publish the new version of packages? This is unfortunately real blocker for legal use of some other packages, like Storybook. Thanks 👍

opichals commented 6 years ago

@boopathi As @pksunkara suggested in order to fix the missing license files a lerna publish --force-publish is necessary to force a new patch version releases.