search

babel / website

:globe_with_meridians: The Babel documentation website
https://babeljs.io/docs/en/index.html
MIT License
752 stars 1.31k forks source link

fix dark mode primary colors #2734

Closed JLHwung closed 1 year ago

JLHwung commented 1 year ago

The dark mode primary colors seem not working.

Currently main:

image

Expected:

image
netlify[bot] commented 1 year ago

Deploy Preview for babel ready!

Name Link
Latest commit f07095e48814f17624f312e418265e6bbee81aca
Latest deploy log https://app.netlify.com/sites/babel/deploys/63f93241d5c16d0008970a17
Deploy Preview https://deploy-preview-2734--babel.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

liuxingbaoyu commented 1 year ago

The new colors seem a bit too bright to me. (especially links)

JLHwung commented 1 year ago

Technically they are not new colors, they were included in #2622 and they are derived directly from the brand color. For some reason they are not enabled in #2622 and this PR fixes that.

Personally I prefer themes in this PR.