Closed Armanio closed 1 month ago
Name | Link |
---|---|
Latest commit | 6fb45be3e57d5cbe53aacb71641072e957eac96e |
Latest deploy log | https://app.netlify.com/sites/babel-next/deploys/66a7b3027827810008486d04 |
Deploy Preview | https://deploy-preview-2908--babel-next.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 6fb45be3e57d5cbe53aacb71641072e957eac96e |
Latest deploy log | https://app.netlify.com/sites/babel/deploys/66a7b302c32c04000903852a |
Deploy Preview | https://deploy-preview-2908--babel.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thank you for your PR. Yes the :::
is not meant to be in the final html, but removing it is not better as it is supposed to close the opening :::babel8
, a custom markdown directive that we use to build Babel 8 docs website from the same markdown files.
Do you want to take a look at the remark plugin? https://github.com/babel/website/blob/449f038a14f8fbb37d1590f745ed3055bb4dd136/website/docusaurus.config.js#L87-L119
Here we should remove everything inclusively between :::babel8
and :::
when the environment variable BABEL_8_BREAKING
is not enabled.
Oh of course! tip
directive is children babel7
.
Okay, what is correct behaviour? Its incorrect mark up or incorrect directive processing and we need support directive inside directive?
Oh of course!
tip
directive is childrenbabel7
. Okay, what is correct behaviour? Its incorrect mark up or incorrect directive processing and we need support directive inside directive?
I think we should already support nested directives. I didn't investigate this yet, but my gut is that the remark AST is not correct, it seems like the :::
is not recognized as the end of the :::babel7
directive, but rather a paragraph. You can inspect the remark AST via the root
variable.
I just pushed the new fix, this is a leftover from https://github.com/babel/website/pull/2848#issue-1988368133. Thanks for reporting this issue.
Hi! I notice rubbish on options page. My PR drop unused text.