maven-assembly-plugin configuration errors in POM

babelfish-for-postgresql / babelfish_compass

Babelfish Compass: compatibility assessment tool for Babelfish for PostgreSQL

Apache License 2.0

108 stars 21 forks source link

maven-assembly-plugin configuration errors in POM #13

Closed brtrvn closed 2 years ago

brtrvn commented 2 years ago

The <configuration> tag for the maven-assembly-plugin does not use <source> or <target> like the maven-compiler-plugin does.

hsuamz commented 2 years ago

@brtrvn : Thanks for submitting the change. To confirm, would you be OK if we closed this issue? Thanks.

brtrvn commented 2 years ago

Absolutely!

What we've been doing in our repo is "linking" PRs and Issues which automagically closes issues when the resolving PR is merged into main. It also automatically adds "mentioned" comments in the PR and the Issue so you can easily see the connection.