search

babelfish-for-postgresql / babelfish_compass

Babelfish Compass: compatibility assessment tool for Babelfish for PostgreSQL
Apache License 2.0
108 stars 21 forks source link

maven-assembly-plugin does not use source or target in its configuration #14

Closed brtrvn closed 2 years ago

brtrvn commented 2 years ago

Description

Remove incompatible and tags from the maven-assembly-plugin configuration

Issues Resolved

Resolves issue #13

Check List

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

robverschoor commented 2 years ago

ran checks - all OK

brtrvn commented 2 years ago

You approved this pull request and then closed it without merging it. I'm confused.

robverschoor commented 2 years ago

Eh? Did i miss something? Sorry for that. Please advise.

Rob Verschoor AWS | Principal Database Engineer, Aurora/PostgreSQL @.**@.> | T +31-655-772131<tel:+31-655-772131> | twitter: @rob_verschoor

On 1 Nov 2021, at 18:18, brtrvn @.***> wrote:



You approved this pull request and then closed it without merging it. I'm confused.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/babelfish-for-postgresql/babelfish_compass/pull/14#issuecomment-956424578, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVYPZMDCNDELJXY5JNSAOA3UJ3DUPANCNFSM5G5VSWJA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Amazon Development Center (Netherlands) B.V., Johanna Westerdijkplein 1, 2521 EN The Hague, Registration No. Chamber of Commerce 56869649, VAT: NL 852339859B01