babelfish-for-postgresql / babelfish_compass

Babelfish Compass: compatibility assessment tool for Babelfish for PostgreSQL
Apache License 2.0
108 stars 21 forks source link

Dismisses stale pull request approvals when new commits are pushed #4

Closed congoamz closed 2 years ago

congoamz commented 2 years ago

Currently, pull request approvals are still applied when new commits are pushed to a PR. This means that the PR author would be able to merge in changes in the new commits that haven't necessarily been reviewed yet. This behaviour can be blocked by changing the branch protection settings for the repo. Follow this guide to create a new branch protection rule that dismisses stale pull request approvals when new commits are pushed:

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule#creating-a-branch-protection-rule