search

babelfish-for-postgresql / babelfish_compass

Babelfish Compass: compatibility assessment tool for Babelfish for PostgreSQL
Apache License 2.0
108 stars 21 forks source link

Emoji not rendered correctly on MacOs #44

Closed robverschoor closed 2 years ago

robverschoor commented 2 years ago

The Babelfish Compass reports generate some lines which start with an emoji to indicate the line has a cursor pop-up with additional information. The emoji is http://www.unicode-symbol.com/u/1F6C8.html and on Windows it renders correctly in Firefox, Edge and Chrome, it looks like this: image

However, there have been cases where on MacOS the emoji is rendered incorrectly in Safari and Firefox, looking like a square with hexadecimal digits inside, like this: image

However, there have also been reports that the emoji is rendered correctly in MacOS Safari.

In order to get to the bottom of this, a developer with MacOS is invited to participate in this.

laurenz commented 2 years ago

I am certainly not a MacOS expert, but this looks like the character is recognized correctly, but some fonts are missing.

brtrvn commented 2 years ago

What about using this symbol/emoji instead?

http://www.unicode-symbol.com/u/2139.html https://unicode-table.com/en/2139/

Just did a quick test on Mac and Windows 2019 and it renders correctly on both. I can create a PR.

Note that there are other emojis/symbols that also don't render properly on Mac (haven't tried Linux yet). For example, the "book" icon 🕮 is another that we would need to find a replacement for.

robverschoor commented 2 years ago

This has been fixed in Compass version 2022-02, using a different emoji which appears to render OK on MacOS