coveralls
commented
1 month ago Pull Request Test Coverage Report for Build 9233588936
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 21268 unchanged lines in 94 files lost coverage.
- Overall coverage decreased (-37.0%) to 35.897%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| contrib/babelfishpg_tds/src/backend/tds/tds_srv.c | 1 | 89.15% | ||
| contrib/babelfishpg_tsql/src/collationproperty.c | 1 | 92.86% | ||
| contrib/babelfishpg_tds/src/include/tds_request.h | 1 | 73.8% | ||
| contrib/babelfishpg_common/src/encoding/mb/conversion_procs/utf8_and_uhc/utf8_and_uhc.c | 2 | 0.0% | ||
| contrib/babelfishpg_tds/src/backend/tds/err_handler.c | 2 | 73.79% | ||
| contrib/babelfishpg_tsql/src/pl_comp-2.c | 3 | 89.29% | ||
| contrib/babelfishpg_tsql/src/tsqlIface.hpp | 3 | 84.21% | ||
| contrib/babelfishpg_tds/src/backend/tds/tdsprotocol.c | 3 | 64.46% | ||
| contrib/babelfishpg_common/src/encoding/mb/conversion_procs/utf8_and_gbk/utf8_and_gbk.c | 4 | 0.0% | ||
| contrib/babelfishpg_common/src/encoding/mb/conversion_procs/utf8_and_sjis/utf8_and_sjis.c | 4 | 0.0% | ||
| <!-- | Total: | 21268 | --> |
| Totals | |
|---|---|
| Change from base Build 9225975685: | -37.0% |
| Covered Lines: | 20637 |
| Relevant Lines: | 57490 |
Description
Currently,
definitioncolumn in the view sys.sql_modules stores upto 4000 characters. SSMS scripting uses sys.sql_modules view to show the definition of the procedure, and the procedure definition is truncated to 4000 characters if the actual procedure definition is more than 4K.To avoid this incorrect definition, We can directly use
sys.nvarcharand there is no need to specify the tymod of 4000 in case of sys.nvarchar for the definition column i.e.,sys.nvarchar(4000).Fixed the definition column for the views which should use nvarchar(max): sql_modules, system_sql_modules, all_sql_modules.
Issues Resolved
Task: BABEL-4870 Signed-off-by: Shalini Lohia lshalini@amazon.com
Test Scenarios Covered
Use case based - Added test in DDL test framework. Also, testing using SSMS.
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -