babelfish-for-postgresql / babelfish_extensions

Babelfish for PostgreSQL provides the capability for PostgreSQL to work with applications written for Microsoft SQL Server. Babelfish understands the SQL Server wire-protocol and T-SQL, the Microsoft SQL Server query and procedural language, so you don’t have to switch database drivers or rewrite all of your application queries.
https://babelfishpg.org/
Apache License 2.0
274 stars 93 forks source link

Reset proconfig for functions even when babelfish is installed #2641

Closed tanscorpio7 closed 2 months ago

tanscorpio7 commented 4 months ago

Description

If babelfish is installed the set_sql_dialect is installed. That means we were never resetting the proconfig values for triggers/functions. One major symptom of this is mVU failure when there are some other extensions installed which change search path in proconfig.

Issues Resolved

[BABEL-4982]

Engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/382

Extension PR: https://github.com/babelfish-for-postgresql/babelfish_extensions/pull/2641

Sign Off

Signed-off-by: Tanzeel Khan tzlkhan@amazon.com

Check List

By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9351348019

Details


Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 2 74.29%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9313151345: 0.002%
Covered Lines: 41909
Relevant Lines: 57487

💛 - Coveralls
2jungkook commented 2 months ago

Next time, please refrain from using a test file name like BABEL-XXX.