babelfish-for-postgresql / babelfish_extensions

Babelfish for PostgreSQL provides the capability for PostgreSQL to work with applications written for Microsoft SQL Server. Babelfish understands the SQL Server wire-protocol and T-SQL, the Microsoft SQL Server query and procedural language, so you donโ€™t have to switch database drivers or rewrite all of your application queries.
https://babelfishpg.org/
Apache License 2.0
274 stars 93 forks source link

Restrict dropping of specific extended stored procedures #2685

Closed roshan0708 closed 3 months ago

roshan0708 commented 3 months ago

Description

This commit adds a check to prevent dropping of specific extended stored procedures:

These procedures are critical and should not be dropped accidentally.

Issues Resolved

Task: BABEL-4390

Test Scenarios Covered

Check List

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9668571287

Details


Totals Coverage Status
Change from base Build 9647525510: 0.001%
Covered Lines: 42827
Relevant Lines: 58500

๐Ÿ’› - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9682613281

Details


Totals Coverage Status
Change from base Build 9647525510: 0.002%
Covered Lines: 42831
Relevant Lines: 58504

๐Ÿ’› - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9682796338

Details


Totals Coverage Status
Change from base Build 9647525510: 0.002%
Covered Lines: 42831
Relevant Lines: 58504

๐Ÿ’› - Coveralls
shalinilohia50 commented 3 months ago
  1. Please update the PR description accordingly. Add Signed-off-by: too.
  2. Shouldn't we add tests to other schedule files as well? Or just latest/schedule is enough?
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9693182411

Details


Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 3 73.33%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 9647525510: -0.003%
Covered Lines: 42828
Relevant Lines: 58504

๐Ÿ’› - Coveralls