babelfish-for-postgresql / babelfish_extensions

Babelfish for PostgreSQL provides the capability for PostgreSQL to work with applications written for Microsoft SQL Server. Babelfish understands the SQL Server wire-protocol and T-SQL, the Microsoft SQL Server query and procedural language, so you don’t have to switch database drivers or rewrite all of your application queries.
https://babelfishpg.org/
Apache License 2.0
265 stars 87 forks source link

Remove error context handling from string literal hook #2695

Open staticlibs opened 5 days ago

staticlibs commented 5 days ago

Description

This change removes error context handling call from string literal hook. It seems to be better to have this call in engine so it happens on all code paths. Hook signature is simplified because passing parser state is no longer needed.

Engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/397

Issues Resolved

2693

Test Scenarios Covered

Added the crash reproducer to babel_726 test.

Check List

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Alex Kasko alex@staticlibs.net

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9715452686

Details


Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 3 73.33%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 9647525510: -0.006%
Covered Lines: 42821
Relevant Lines: 58497

💛 - Coveralls