Add tests for crash due to uninitialized rte->relid in temp table with trigger

babelfish-for-postgresql / babelfish_extensions

Babelfish for PostgreSQL provides the capability for PostgreSQL to work with applications written for Microsoft SQL Server. Babelfish understands the SQL Server wire-protocol and T-SQL, the Microsoft SQL Server query and procedural language, so you don’t have to switch database drivers or rewrite all of your application queries.

https://babelfishpg.org/

Apache License 2.0

265 stars 87 forks source link

Add tests for crash due to uninitialized rte->relid in temp table with trigger #2696

Closed timchang514 closed 1 day ago

timchang514 commented 5 days ago

Description

Fixing a crash in temp tables with trigger. rte->relid was uninitialized in addRangeTableEntryForENR when dealing with TSQL temp tables, causing an assert to fail. Adding tests for this change.

Issues Resolved

BABEL-5071 BABEL-4992

Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

coveralls commented 2 days ago

Pull Request Test Coverage Report for Build 9748293424

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.197%

Totals
Change from base Build 9741952034:	0.0%
Covered Lines:	42834
Relevant Lines:	58519

💛 - Coveralls

coveralls commented 2 days ago

Pull Request Test Coverage Report for Build 9748364115

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 73.2%

Totals
Change from base Build 9741952034:	0.003%
Covered Lines:	42836
Relevant Lines:	58519

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9764815984

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.197%

Totals
Change from base Build 9741952034:	0.0%
Covered Lines:	42834
Relevant Lines:	58519