ALTER PROCEDURE throwing unexpected state error

[Jakeowen1]

Description

This change prevents certain alter procedure calls in PSQL dialect from attempting to use the TSQL alter procedure implementation by adding a dialect check. Procedures created in PSQL and altered with security definer would throw the following error ERROR: StartTransactionCommand: unexpected state STARTED

Issues Resolved

Task: BABEL-5074

Test Scenarios Covered

• Use case based -

  jdbc_testdb=# CREATE PROCEDURE master_dbo.p1() AS $$ BEGIN SELECT 1; END $$ LANGUAGE plpgsql;
  CREATE PROCEDURE
  jdbc_testdb=# ALTER PROCEDURE master_dbo.p1 security definer;
  ALTER PROCEDURE

Check List

• [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 9764286931

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 48 of 50 (96.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 73.197%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contrib/babelfishpg_tsql/src/pl_handler.c	48	50	96.0%
<!--	Total:	48	50	96.0%	-->

Totals
Change from base Build 9741952034:	0.0%
Covered Lines:	42837
Relevant Lines:	58523

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9765505829

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 48 of 50 (96.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 73.197%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contrib/babelfishpg_tsql/src/pl_handler.c	48	50	96.0%
<!--	Total:	48	50	96.0%	-->

Totals
Change from base Build 9741952034:	0.0%
Covered Lines:	42837
Relevant Lines:	58523

---

💛 - Coveralls