Closed ahmed-shameem closed 3 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
contrib/babelfishpg_tsql/src/procedures.c | 63 | 74 | 85.14% | ||
<!-- | Total: | 63 | 74 | 85.14% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
contrib/babelfishpg_tsql/src/procedures.c | 5 | 88.33% | ||
<!-- | Total: | 5 | --> |
Totals | |
---|---|
Change from base Build 9717094469: | -0.009% |
Covered Lines: | 42828 |
Relevant Lines: | 58513 |
Description
In our previous attempt of fixing sp_describe_undeclared_parameters related crash, we missed some corner cases where few variables will be left NULL if is_sp_describe_undeclared_parameters is marked as false. Then when we try to access those variables, we get seg fault. In this commit, we fix it by adding extra check on is_sp_describe_undeclared_parameters. Issues Resolved
Issues Resolved
BABEL-5068 Signed-off-by: Shameem Ahmed shmeeh@amazon.com
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.