search

babelfish-for-postgresql / babelfish_extensions

Babelfish for PostgreSQL provides the capability for PostgreSQL to work with applications written for Microsoft SQL Server. Babelfish understands the SQL Server wire-protocol and T-SQL, the Microsoft SQL Server query and procedural language, so you don’t have to switch database drivers or rewrite all of your application queries.
https://babelfishpg.org/
Apache License 2.0
274 stars 93 forks source link

Re-enable "Fix concurrency issues with ENR temp tables." #2895

Closed Sairakan closed 3 weeks ago

Sairakan commented 1 month ago

Description

https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/commit/5140f79a8ebbf37e0eea6527532f77cf7fa4d0c7 had a bug which caused a crash when aborting nested transactions with table variables due to missing a case when a lock was being acquired during table creation. Fix that case by adding a proper check for ENR-ness, and skip the lock acquisition in that case.

Issues Resolved

BABEL-4913, BABEL-4892

Test Scenarios Covered

Check List

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10620854567

Details

Totals Coverage Status
Change from base Build 10599358782: 0.1%
Covered Lines: 44601
Relevant Lines: 60114
💛 - Coveralls