search

babelouest / glewlwyd

Experimental Single Sign On server, OAuth2, Openid Connect, multiple factor authentication with, HOTP/TOTP, FIDO2, TLS Certificates, etc. extensible via plugins
https://babelouest.github.io/glewlwyd
Other
430 stars 80 forks source link

[Issue] OIDC plugin prevents changing the session cookie name #198

Closed ghost closed 2 years ago

ghost commented 2 years ago

Describe the issue Configuring the OIDC module prevents custom session id name, un-checking ends up with value NaN which still cannot be overridden

To Reproduce

  1. Go to Parameters | Plugins | Add
  2. SelectOpenID Connect
  3. Fill up the mandatory fields
  4. Check Allow session management endpoints
  5. Try to change the OIDC session cookie name value. It does not allow it
  6. Un-check Allow session management endpointsyou get aNaN` as the value

Expected behavior To be allowed to change the value to a custom value such as SEC_OIDC_SID etc.

Screenshots image

System (please complete the following information): OS/Environment Ubuntu 20.04 Browser used [e.g. Mozilla Firefox 69, Chrome 77, lynx 2.9] Glewlwyd Version 2.6.2 Source installation Docker image (Docker hub)

babelouest commented 2 years ago

Hello @timmotw ,

Indeed, thanks for noticing. I'll make the fix soon, it will be available in the 2.7 release.