search

babelouest / rhonabwy

Javascript Object Signing and Encryption (JOSE) library - JWK, JWKS, JWS, JWE and JWT
https://babelouest.github.io/rhonabwy/
GNU Lesser General Public License v2.1
45 stars 21 forks source link

Suggestion: Rename r_jwks_import_from_str() to r_jwks_import_from_json_str() #7

Closed mkauf closed 3 years ago

mkauf commented 3 years ago

I think the function r_jwks_import_from_str() should be renamed to r_jwks_import_from_json_str(). There are already related functions that also have "json" in the name, e.g. r_jwks_export_to_json_str() and r_jwk_import_from_json_str().

babelouest commented 3 years ago

Hello @mkauf , good call, I must have been distracted at that time.

mkauf commented 3 years ago

Thank you for renaming the function :-)