babelshift / SteamWebAPI2

🎮 C# / .NET library that makes it easy to use the Steam Web API. It conveniently wraps around all of the JSON data and ugly API details with clean methods, structures and classes.
MIT License
263 stars 43 forks source link

Dota web api -> GetMatchDetails response issue #120

Closed Dmitriy-ksm closed 2 years ago

Dmitriy-ksm commented 2 years ago

GetMatchDetails has recently been updated. Added new fields to the answer. For MatchPlayer - net_worth, aghanims_scepter, aghanims_shard, moonshard. And for MatchDetailResult - flags (to be honest, now I have no idea what this field is responsible for, but since the server returns it, it may have a use.). Also, some characters (as far as I know, there are only 3 of them - Lone Druid, Arc Warden and Meepo) for MatchPlayer have an additional_units field. Its usefulness is questionable for Meepo & Warden, but may be useful when we talk about Lone Druid or AD mode with Lone Druid skills in MatchPlayer - 'net_worth aghanims_scepter aghanims_shard moonshard' fields MatchPlayer - 'additional_unis' field MatchDetailResult - 'flags' field

babelshift commented 2 years ago

@Dmitriy-ksm is this issue now resolved after merging #121? Thanks.

Dmitriy-ksm commented 2 years ago

Yes. It might be worth keeping in mind that there is no "flags" field in the MatchDetailResult when merging 121. I'll leave it (Add field to answer or not) up to you. The problem can be closed