babenkoivan / elastic-migrations

Elasticsearch migrations for Laravel
MIT License
189 stars 32 forks source link

elastic:migrate clashes with the scout-elasticsearch-driver adapater #2

Closed MilosMosovsky closed 4 years ago

MilosMosovsky commented 4 years ago

Hello, I just installed your package and seems like you are using same signature elastic:migrate for migrating inside https://github.com/babenkoivan/scout-elasticsearch-driver and https://github.com/babenkoivan/elastic-migrations this makes them clash and when installed in parallel it automatically picks the one from driver ...

Is it possible to namespace commands in this package to some different so it doesn't clash? Thanks!

babenkoivan commented 4 years ago

Hi @MilosMosovsky, it's indeed a problem. https://github.com/babenkoivan/scout-elasticsearch-driver is outside the new stack scope, I didn't expect it will be used in combination with the new elastic-migrations library :)

Anyways, I'd prefer to rename namespace in https://github.com/babenkoivan/scout-elasticsearch-driver and not in the elastic-migrations, but that would require releasing a new version due to interface change. I'll do so if there will be more complains on this topic.

Regarding the ongoing issue, you can fix it in your project by creating a command, which extends ElasticMigrations\Console\MigrateCommand, but has a different signature.

MilosMosovsky commented 4 years ago

@babenkoivan Thanks I did it already, if https://github.com/babenkoivan/scout-elasticsearch-driver is outside of a new scope what else do you propose for the new stack ? I just started the project and I would not like to have already obsolete stack :)

I just need simple setup scout search + index migrations. Do you advice to eject from scout and use client directly ?

babenkoivan commented 4 years ago

@MilosMosovsky have a look at elastic-scout-driver and elastic-scout-driver-plus, this combination is more flexible, than the old driver. You can also refer to this tutorial for more usage examples.

MilosMosovsky commented 4 years ago

Thanks @babenkoivan !

babenkoivan commented 4 years ago

Closing due to inactivity