search

babenkoivan / elastic-migrations

Elasticsearch migrations for Laravel
MIT License
189 stars 32 forks source link

Use `delete()` instead of `truncate()` in Migration Repository #35

Closed stevebauman closed 2 years ago

stevebauman commented 2 years ago

Closes https://github.com/babenkoivan/elastic-migrations/issues/34

Unfortunately I'm not able to emulate the database transaction closing with SQLite upon truncate() (SQLite will execute a DELETE statement since it apparently does not support truncates).

I did however add a sanity test so we're sure all records are actually deleted with delete().

If you'd like me to scaffold a GitHub test action with a MySQL instance to run the tests on let me know! 👍

stevebauman commented 2 years ago

Ok all set, apologies for the lateness.

babenkoivan commented 2 years ago

Thank you @stevebauman, it is now published as v2.0.1.

stevebauman commented 2 years ago

Awesome thanks @babenkoivan! 👍