search

babenkoivan / elastic-migrations

Elasticsearch migrations for Laravel
MIT License
189 stars 32 forks source link

add pending option to elastic:migrate:status command #52

Closed maximepvrt closed 1 year ago

maximepvrt commented 1 year ago

same as migrate:status --pending https://github.com/laravel/framework/blob/ca546893cb98a633daf8be6fdd286faa05c9044d/src/Illuminate/Database/Console/Migrations/StatusCommand.php#L79

maximepvrt commented 1 year ago

👀 @babenkoivan

maximepvrt commented 1 year ago

@babenkoivan PR updated ;-)

babenkoivan commented 1 year ago

Hey @maximepvrt, thank you for updating the PR!

I've discovered that Illuminate\Console\View\Components\Factory is not supported by Laravel 6, and I don't want to lose compatibility because of such a small change. In addition, I forgot to ask you to update the tests and the documentation.

I didn't want to make you rewrite the code again and wait until I had time to review it, so I made the changes myself (based on your code) and published a new version v3.4.0, which includes --pending option for the status command 🙂

maximepvrt commented 1 year ago

rewrite the code is a good exercice 😝 but thanks 😊