search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.34k stars 102 forks source link

Black borders around grid view when scrollbars are displayed #121

Closed null-von-sushi closed 7 years ago

null-von-sushi commented 7 years ago

Bookwork shows a black border when using the grid view and you have more books then there is space on your screen causing scrollbars to be used. This issue disappears if I resize the window to make it large enough so the scrollbars disappear, or I remove some books from my library (which would also cause the scrollbars to disappear).

Terminal output when running bookworm: https://hastebin.com/tudamuxuni.pas

I am using GNOME Shell v. 3.24.2 on Antergos. This also occurs when using the default Adwaita theme black

babluboy commented 7 years ago

I guess this is a theme issue. Did you turn on the dark theme in the Bookworm preferences ? I wonder why the grid background is not being dark which is why it looks like a dark border. This is how Bookworm looks like on Elementary when I turn on Dark Mode in the preferences...

screenshot from 2017-09-02 21 22 40

null-von-sushi commented 7 years ago

Oh yeah, I did try toggling dark mode. It turns the white spaces into dark ones (as it is supposed to), however the black bar remains. I am not sure if it is a theme thing, since the default Adwaita theme also causes this. If you want, I can try installing whatever theme elementary OS ships with?

babluboy commented 7 years ago

I saw that I was setting a border width on the Gtk.Grid which is probably why the black border was showing. This is how it looks like if I set the border to zero. But not sure if it looks good without the borders on the left and top...the scroll bar also comes overlay on the covers on the right...let me know what you think...

screenshot from 2017-09-04 22 50 21

ckrzen commented 7 years ago

I like the black border. I also use the 'Adwaita-dark' GTK theme, though.

On Mon, Sep 4, 2017 at 4:54 PM Siddhartha Das notifications@github.com wrote:

I saw that I was setting a border width on the Gtk.Grid which is probably why the black border was showing. This is how it looks like if I set the border to zero. But not sure if it looks good without the borders on the left and top...the scroll bar also comes overlay on the covers on the right...let me know what you think...

[image: screenshot from 2017-09-04 22 50 21] https://user-images.githubusercontent.com/14061478/30039060-dfc5be4e-91c3-11e7-89a5-7181b31323a1.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/babluboy/bookworm/issues/121#issuecomment-327032405, or mute the thread https://github.com/notifications/unsubscribe-auth/AGnuRR2NUMt13-5H2AxEt7xO4EeSQ-LRks5sfHF-gaJpZM4PK9XZ .

babluboy commented 7 years ago

I think I have fixed the issue which will remove the black border around the grid, but will still have a border. I have just shifted the border from the container Gtk.Grid to the individual EventBox cover images. The latest code is on GH (if building from source) or on the daily PPA (ppa:bablu-boy/bookworm-daily)...will be great if you can check on your system to see how it looks...here are screenshots from elementary in the light and dark modes...

screenshot from 2017-09-05 09 03 40 screenshot from 2017-09-05 09 03 10

ckrzen commented 7 years ago

Looks great.

On Tue, Sep 5, 2017 at 3:34 AM Siddhartha Das notifications@github.com wrote:

I think I have fixed the issue which will remove the black border around the grid, but will still have a border. I have just shifted the border from the container Gtk.Grid to the individual EventBox cover images. The latest code is on GH (if building from source) or on the daily PPA (ppa:bablu-boy/bookworm-daily)...will be great if you can check on your system to see how it looks...here are screenshots from elementary in the light and dark modes...

[image: screenshot from 2017-09-05 09 03 40] https://user-images.githubusercontent.com/14061478/30052455-6905e22a-921d-11e7-83a8-dcb10b955bb7.png [image: screenshot from 2017-09-05 09 03 10] https://user-images.githubusercontent.com/14061478/30052456-69075290-921d-11e7-948b-ef08fda65a12.png

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/babluboy/bookworm/issues/121#issuecomment-327109256, or mute the thread https://github.com/notifications/unsubscribe-auth/AGnuRWNe57FxHGHknQoByUDVQxg6OxZlks5sfQeygaJpZM4PK9XZ .

null-von-sushi commented 7 years ago

Yeah, everything looks as it should now. Thanks for fixing it :slightly_smiling_face: