search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 100 forks source link

Background for comics should not be chromatized by default #190

Open Shnatsel opened 6 years ago

Shnatsel commented 6 years ago

The default background when reading comics is the background color from Solarized Dark theme, with a distinct cyan tint. This is fine for text, which is black-and-white anyway, so you can mess with colors as you please.

However, chromatized background is not a great idea when dealing with images. It is distracting at best and throws off color perception in the image at worst. Simply reusing the default elementary dark theme background (which is neutral in terms of color) as background for comics would make a big difference.

Screenshot to back it up: screenshot from 2018-04-12 03-28-36

babluboy commented 6 years ago

@Shnatsel Thanks for raising this. A lot of user preferred different tints for the three profile colors. So I created a customization in the preferences where you can modify the background and foreground colors for each of the three profiles from the color palette or by adding your own hex code. May be you can use one profile for comics and one for text. Hopefully this resolves your issue - but let me know if you want to discuss further. Here is a screen shot for setting the color on a profile from the preference menu. screenshot from 2018-04-12 22 40 56

Shnatsel commented 6 years ago

I am aware that I could edit a color profile and manually switch between them for text and comics. However, it is cumbersome. Besides, I've come to expect elementary OS applications to not require any configuration and to provide a good experience out of the box, as per the HIG.

babluboy commented 6 years ago

I see your point, may be one way would be to let the user associate a ebook type with a specific profile and then allow the user to customise the profile. But I'm not convinced that many users will switch between ebooks and comics frequently enough to justify this. Also I'm not sure if the default solarised dark theme is that bad for comics. Can you please provide the hex code of the elementary dark theme you are suggesting as the dark theme for comics. I can then check the difference.

Shnatsel commented 6 years ago

This is what Eye of GNOME looks like when using default background from the GTK theme:

screenshot from 2018-04-13 03-17-24

I've also tried Pantheon Photos but it's not a fair comparison because it always uses a checkered background to make transparency visible, which is not a concern for comics.

babluboy commented 6 years ago

Thanks....this looks good indeed...I will try and see if I can get the hex code for that eye of gnome background...