search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.34k stars 102 forks source link

Expose icon sizes for adjustment by user (on different themes) #240

Open iamlemec opened 5 years ago

iamlemec commented 5 years ago

This is a really small one-liner, so I'll just describe it. I can make a pull request if you'd like.

Currently the hamburger menu icon in the toolbar looks blurry, presumably because it is too small and zoomed:

hamburger1

If you change the icon size on bookworm.vala:330 from LARGE_TOOLBAR to MENU, it looks much better:

hamburger2

Btw, I'm running Fedora 29 with Adwaita icon theme.

Thanks for an awesome ereader!

babluboy commented 5 years ago

@iamlemec Thanks for your interest in Bookworm. This is how it looks like on Elementary OS the targetted distro for Bookworm. screenshot from 2019-02-23 14 38 29

If I remember correctly, the Gear Icon seemed small if I reduce the size on eOS. So this is a tricky situation and I want Bookworm to look good on all distros. Let me change the icon size and see how it looks on eOS.

iamlemec commented 5 years ago

Oh interesting. Yeah, the hicolor icon theme I have uses that same gear, and it does look a bit small with menu size.

babluboy commented 5 years ago

Here are the gear items in LARGE_TOOLBAR and MENU sizes, the MENU size looks too small, so unfortunately I will not change it to MENU but would need to think of a way later to suit different icon themes. Maybe expose the size as a custom item in a config file which the user can play around...

MENU-Gear Large-gear