FUNCTION:createAnnotationDialog when read specific epub files

dmitriiweb commented 5 years ago

The application can't render some epub files. When I click on a book in the Library, I see only empty pages. When I click navigation button then appear pop-up dialog "Edit annotation for <link rel="stylesheet" href..." debug.txt

babluboy commented 5 years ago

@dmitriiweb Many thanks for your interest in Bookworm and logging this issue. Would you be able to attach the mobi file giving the issue or send it to my email: bablu.boy@gmail.com

I will try and reproduce the issue at my end to help me debug the issue.

dmitriiweb commented 5 years ago

@babluboy I've sent you an email

dmitriiweb commented 5 years ago

@babluboy Also you can use any epub file from this website: http://flibusta.is/

babluboy commented 5 years ago

Thanks - I have replicated the issue. There must be some content in the epubs from this site that is conflicting with the code. Will check and let you know as sook as I fix it

dmitriiweb commented 5 years ago

@babluboy Thanks. I also checked such files in other readers, and they read these files without any issues.

babluboy commented 5 years ago

@dmitriiweb Turns out that this was caused by an empty title tag in the ebook contents i.e. I have made a fix to remove the empty title tag before rendering the contents, and it seems to have fixed the issue. Will be great if you can build from source and test it on some of the books on <a href="http://flibusta.is/">http://flibusta.is/</a></p> <p>Hopefully this makes Bookworm a bit better and compatible in handling books with empty title tag contents.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dmitriiweb"><img src="https://avatars.githubusercontent.com/u/21336025?v=4" />dmitriiweb</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Excellent! Thank you!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/babluboy"><img src="https://avatars.githubusercontent.com/u/14061478?v=4" />babluboy</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>@dmitriiweb No worries. Let me know when you have checked and confirm the fix works for opening the similar books from <a href="http://flibusta.is/">http://flibusta.is/</a> which were having the issue earlier.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dmitriiweb"><img src="https://avatars.githubusercontent.com/u/21336025?v=4" />dmitriiweb</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>@babluboy Thank you, all working fine. Awesome!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/babluboy"><img src="https://avatars.githubusercontent.com/u/14061478?v=4" />babluboy</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>great !...thanks for checking. Will try to put in some more changes/fixes and release this as part of 1.1.2 release</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

babluboy / bookworm

FUNCTION:createAnnotationDialog when read specific epub files #243