search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 100 forks source link

Feature Request: option to center textbody, set textbody width manually #273

Open MayorUshanka opened 5 years ago

MayorUshanka commented 5 years ago

Hello! I just downloaded bookworm, and the options to set margins are unsatisfactory. Really, I need to open the settings, click the "larger margins" button, repeat 10x, only to find out that the body of text has shifted to the left and is still way too wide?

As a side note, a default body width of 80ch would be nice.

babluboy commented 4 years ago

Thanks for raising the issue, it will be great if you can send me a screenshot after you have extended or shrunk the margins to the max extent. That will give me an idea on why the margins adjustment is not working as expected.

aeosynth commented 4 years ago

it will be great if you can send me a screenshot after you have extended or shrunk the margins to the max extent

that's a very tedious task which shouldn't be necessary in the first place; the body should automatically be centered.

babluboy commented 4 years ago

The text should be centered by default unless some formatting in the ebook is causing the issue. Will it be possible to send me the ebook - either attach it here or email the same to me : bablu.boy@gmail.com

That will help me replicate the issue and take a look at what is causing the same

MayorUshanka commented 4 years ago

I have recorded a video of the issue, and will send the 4 epubs to babluboy https://youtu.be/j2fbNwduMNo

babluboy commented 4 years ago

@MayorUshanka Looked at the four epubs you had sent and the problem was with the CSS in the books itself which was rendering the margins incorrectly. I have made some changes to force the margin CSS in the bookworm style sheet, this kind of resolves the issue where the styles sheets were changing the margin

But it does not completely resolve the issue where the content of the ebook cuts the line width like below:

<p class="calibre1">In  creation  of  a  forensic  image,  we  are  trying  to  capture  an  accurate  as  possible </p>
<p class="calibre1">representation of source media. This is not unlike the police lines set up at a physi-</p>
<p class="calibre1">cal crime scene. These lines are put in place to minimize the amount of change that </p>
<p class="calibre1">occurs in a crime scene, which in turn gives the crime scene investigators the most </p>

I would probably need to extract all text, remove all formatting/styles and apply a stylesheet created for bookworm to render books uniformly.

MayorUshanka commented 4 years ago

@babluboy I’ve looked at the css myself out of interest and I think having an option in bookworm to ignore the supplied css and simply force a bookworm stylesheet might indeed be the best option.