search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 100 forks source link

Feature Request: Auto-hide Horizontal Scroll Bar #284

Open drkui opened 4 years ago

drkui commented 4 years ago

One feature that I would find as a nice addition is to have the option to auto-hide the horizontal scroll bar on the bottom when not in use in full screen mode (F11). Having it disappear after a second or so (or even stay hidden?) would be a more immersive experience.

babluboy commented 4 years ago

@drkui Thanks for raising this issue. I don't remember seeing a horizontal scroll bar - the flow should be to render the content vertically and have a vertical scrolbar only. I also donot remember adding any specific code to either show or prevent a horizontal scrollbar.

It will be great if you can attach the ebook to this issue for me to investigate this further.

johnfactotum commented 4 years ago

I think @drkui is probably referring to the progress bar, similar to #269?

drkui commented 4 years ago

Yes sorry, it's indeed the progress bar. I didn't realize there was an issue about this already, but yes it's similar.

The two suggestions in #269 to either go into full screen or make it slimmer doesn't really address my specific feature request, which is to have the option to auto-hide the progress bar after a certain amount of time (since either way the bar is still there).

babluboy commented 4 years ago

Thanks @drkui and @johnfactotum for clarifying. We will continue to track this on #269 . Closing this Issue.

babluboy commented 4 years ago

@drkui I checked that in Full Screen mode the progress bar is not shown and you can navigate with arrow keys. Please check #63 which has already been implemented. You can enter ful screen either with F11 or from the right click context menu on the reading mode

drkui commented 4 years ago

@babluboy Thanks for following up, I rechecked and I'm still seeing the progress bar on the bottom in full screen mode.

85VnqcO

babluboy commented 4 years ago

@drkui That is strange. Can you check if your bookworm version is 1.1.2 or different? You can find the version from the About menu on the gear icon on top right

drkui commented 4 years ago

@babluboy Just checked and I do indeed have 1.1.2, installed from AUR.

babluboy commented 4 years ago

I have replicated the issue. This bug must have come in while impementing #194 You can right click and select Enter Full Screen and then the progress bar is removed. However the context menu and F11 and Esc gets out of sync with each other causing this issue.

Will fix this soon.

cyberjaguar commented 4 years ago

same here, please let me remove that scrollbar, please! Thanks!

can confirm: via F11 the horizontal scrollbar still shows, but when using the right-click menu to fullscreen it is not shown.

BTW this is not what is usually called a "progress bar" - I would also identify this as a horizontal scrollbar.