search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

refactor contentHandler.adjustPageContent, extract functions.js, styles.css from htmlscripts.txt #297

Closed shiraeeshi closed 4 years ago

babluboy commented 4 years ago

@shiraeeshi Many thanks for your interest and contribution to Bookworm. Can you please mention a couple of lines on the changes for the PR and if possible any screen shots. That will give me a better idea on what the changes impact - will merge after you provide the details

shiraeeshi commented 4 years ago

@babluboy Thanks for creating an opportunity to work on an open source book reader.

I plan to gradually add little refactorings and occasionally a new functionality.

Now I'm working on a shortcuts dialog.

babluboy commented 4 years ago

Thanks I have merged. From a maintenance point of view it’s a good idea to have js and css separated - but will it be improving performance and load time? Will check for the same

babluboy commented 4 years ago

I had not been able to pay attention to bookworm for a couple of months due to my day job. But will start work soon on the pagination function.

Yes, the shortcuts will be a good to have addition within the app. At the moment they are on the website (https://babluboy.github.io/bookworm/). The in-app shortcuts can be based on OS as per #295