babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

can't get dark background for library #300

Open brainchild0 opened 4 years ago

brainchild0 commented 4 years ago

I am unable to find a configuration that causes the library to display with a dark background. The application web site shows such an example in a screenshot. However, configuring a dark theme apparently affects only book content, not library display. Meanwhile, some may have a preference for separate background styles in the two contexts.

As such, I suggest an enhancement that permits the user 1) to employ a dark background for a library, and 2) to do so even with a light background for book content.

babluboy commented 4 years ago

In Elementary OS this is working by turning on dark mode. What distro are you using?

babluboy commented 4 years ago

After turning on dark mode in preference settings (cog wheel icon in library view) the user can still set a light reading profile after opening the ebook and choosing the reading profile under the “Aa” button.

brainchild0 commented 4 years ago

I am using Linux Mint Cinnamon. Switching dark theme affects reading only, not library.

babluboy commented 4 years ago

@brainchild0 There are a number of users who have reported (Issue #290) that after installing bookworm from the Mint (Mint 18.1) Software repo, they cannot find Bookworm application or the command to open it. Will be great if you can share how you got Bookworm working on Mint.

johnfactotum commented 4 years ago

Linux Mint's theme doesn't support gtk-application-prefer-dark-theme: https://github.com/linuxmint/mint-themes/issues/199

brainchild0 commented 4 years ago

I'm not sure what to make of the outstanding lack of support from Mint for dark themes, other than that users may need to be resigned to waiting for support.

I still would suggest separate configurability for the themes used in the cover selection versus the reading. Black print on white background is natural for printed text, but the dark background makes the cover art clearer to see. Or perhaps just use a dark background for cover art and use the selected theme for other display contexts.