search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

shortcuts settings: gschema.xml, dialog.vala, shorcuts.vala #305

Closed shiraeeshi closed 4 years ago

shiraeeshi commented 4 years ago

shortcuts settings: add to gschema.xml, to dialog.vala, refactor shortcuts.vala.

UI is in Preferences Dialog - Shortcuts tab.

shiraeeshi commented 4 years ago

Shortcuts list UI is a little unwieldy, "add shortcut" button is too large, there are no column headers. I plan to tweak and tune it and then add commits to this pull request.

shiraeeshi commented 4 years ago

fixes #294, #295

shiraeeshi commented 4 years ago

partially fixes #231

babluboy commented 4 years ago

@shiraeesi many thanks for your contribution. I will merge this when I get a bit of time from my day job. Just that I understand the work you have done, can you please attach a screenshot of the work here.

shiraeeshi commented 4 years ago

Here is a screenshot. shortcuts-settings

babluboy commented 4 years ago

Thanks for this, I will merge soon and also may work a bit to further refine the UI for the short cuts