Book content disapears

[KjartanOli]

I sucessfully built bookworm from source and the app seems to start normaly. I can see my library but when I try to read any book there is no readable text. I can see the table of contents and the text flashes for a seccond when switching pages.

[thosoo]

happens for me aswell

I am using fedora 32.

[babluboy]

Hi apologies for getting back late. I am not able to reproduce this issue on elementary os, would you be able to run bookworm in debug mode and attach the debug output here for me to check if there is any issue in Fedora.

com.github.blabluboy.bookworm --debug > ~/bookworm_debug.txt

[KjartanOli]

Here is the output of debug mode. Sorry I forgot to mention it but I am running Debian 10 bookworm_debug.txt

[shiznix]

Happens on Gentoo too - a Bookworm issue, not a distro issue.

I thought it was maybe a cache issue, but disabling 'Enable cache' slider caused Bookworm to segfault and coredump :(

Tried rebuilding with older Vala versions and while this reduces the vala compiler warnings, it doesn't fix the issue. Trying to downgrade WebkitGTK from 2.28.2 to 2.26.4 now to see if that fixes the rendering problem...nope :(

[KjartanOli]

Just rebuilt on Debian 11 (Bullseye). It doesn't happen now.

[shiraeeshi]

Reproduced the issue after pulling master branch. I think the issue is caused by the commit Initial changes for splitting chapters to pages.

The "fillPage" function in functions.js file adds opening tag without corresponding closing tag. You can copy html page from cache to another directory, copy functions.js file in the same directory and open an html page in browser and then invoke functions to debug them.

"Work in progress" commits should be committed to another branches, not the master branch.

The issue will be resolved if we move the changes from that commit to a new branch.

[babluboy]

Apologies for looking at this late. Will fix the issue tonight and also try to create a development branch so that work in progress code does not cause issues for people building from the master branch. Not sure why I did not hit the issue on elementary.

@shiraeeshi Thanks for your PR will check and apply it soon.

[shiraeeshi]

Not sure why I did not hit the issue on elementary.

Maybe it depends on the contents of the html file being opened. Not sure about that.

[shiraeeshi]

Just found out that you can use Webkit.WebInspector to debug html and javascript from within the application. Pretty cool stuff.

[babluboy]

Dev branch has been created. I will use the Dev branch to work on the code and push it to master the same time I do a release for Elementary AppCenter. This makes more sense as the master branch is being used by people to build from source and should not have unstable (WIP) code.

[shiraeeshi]

@babluboy Can you undo the changes from the Initial changes for splitting chapters to pages commit in the master branch? You can edit files to undo those changes and make a commit to the master branch.

[babluboy]

@shiraeeshi Is there an easy way to reverse the commit Initial changes for splitting chapters to pages directly on github as other commits after that has no links to this commit ? Thinking of whether I should forward fix or reverse - it should be easy to fix the closing ">" if that is what is causing the issue

[shiraeeshi]

@babluboy I don't know a way to reverse a commit directly on github. You can undo the changes in the master branch, and continue the work on the dev branch.

[babluboy]

Thanks to @shiraeeshi the changes for pagination are reversed(#332) . So this issue should be fixed. Please re-install from master and let me know if this is fixed.