search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

Some scripts are not python3-compatible #330

Open hosiet opened 3 years ago

hosiet commented 3 years ago

Searching "print" in data/scripts/mobi_lib/mobiml2xhtml.py, it seems that there are still some print "abc" statements in the script. I saw some python3 porting work previously but obviously the port was not complete. Since python2 has been end-of-life for nearly a year, the py3 compatibility problem may should be prioritized.

DrDub commented 3 years ago

This is also giving an error when installing on Debian testing.

Besides the 4-5 old-style prints, there seem to be python2 exception handling issues in that file, too.

babluboy commented 3 years ago

Many thanks for raising this - will update the print statements to print(abc) My intention was to port the function to vala and do away with python altogether, but just not getting the time to work on Bookworm. Maybe making the script python3 compatible will be a stopgap option

DrDub commented 3 years ago

It you need help, I can send you a PR for changes that will make it Debian testing installable (I'm not familiar with the codebase to go beyond that).

babluboy commented 3 years ago

Bookworm only requires the mobi unpack script and this commit already makes that python3 compatible. https://github.com/babluboy/bookworm/issues/307

Are these print issues being picked up during installation as these python script are only called during runtime. Hopefully it should not block the install and use of bookworm