babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

Debian package: move ninja to build dependencies #338

Closed ahyattdev closed 3 years ago

ahyattdev commented 3 years ago

Also use the correct name, build-ninja

ahyattdev commented 3 years ago
$ sudo apt-get install com.github.babluboy.bookworm
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 com.github.babluboy.bookworm : Depends: ninja but it is not installable
E: Unable to correct problems, you have held broken packages.

This is what happens when you try to install on Ubuntu.

Also, it is outside of the scope of this PR, but just bookworm would be a more debian-like package name.

babluboy commented 3 years ago

Thanks for the PR, I have merged. On the package naming, I follow the Elementary OS naming standards as Bookworm was developed for this distro. https://github.com/babluboy/bookworm/issues/336#issuecomment-705392700