babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

failed to load the file name for booktitles when in non-english os #341

Open LuckyXixi opened 3 years ago

LuckyXixi commented 3 years ago

Failed to load the file name for booktitles when in non-english os, even if the file name are in english.

I found that in /src/pdfReader.vala +165 has this condition

aBook.getBookTitle () == BookwormApp.Constants.TEXT_FOR_UNKNOWN_TITLE

But in my case (Ubuntu 18.04 Chinese version), I add three info line above:

        info ("aBookTitle: " + aBook.getBookTitle ());
        info ("text for unknown: " + BookwormApp.Constants.TEXT_FOR_UNKNOWN_TITLE.to_string());
        info ("is equal?:  " + (aBook.getBookTitle () == BookwormApp.Constants.TEXT_FOR_UNKNOWN_TITLE).to_string)

and return this:

[INFO 07:32:37.307473] pdfReader.vala:164: aBookTitle: Unknown Book [INFO 07:32:37.307550] pdfReader.vala:165: text for unknown: 未知书籍 [INFO 07:32:37.307590] pdfReader.vala:166: is equal ?: false

So I change the line 165 to aBook.getBookTitle () == "Unknown Book"

that work for me!

Wonder if someone could fix this beautifully