babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

Adapt left-over Python 2 code #346

Closed uhle closed 3 years ago

uhle commented 3 years ago

Fixes #330 although I know this would just be an intermediate solution if you still plan to implement the necessary bits in Vala to get rid of the Python code. But these minor changes would allow the installation on any Debian or Ubuntu based distribution in the meanwhile (cf. flathub/com.github.babluboy.bookworm#15 for instance).

babluboy commented 3 years ago

hi. many thanks for the PR. can you please do a PR into dev branch. the master is the stable branch which people install from and hence the request to change dev and then bundle all changes into master once tested

babluboy commented 3 years ago

I have updated the dev branch with your PR - will check the dev branch soon and bundle with other changes into master when ready for release. Thanks

uhle commented 3 years ago

You're welcome.