search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

fix print in case of python env isn't python2 #368

Open smCloudInTheSky opened 2 years ago

smCloudInTheSky commented 2 years ago

Hello,

I tried to install bookworm on pop os 21.04. Had some errors on the post install script :

Paramétrage de bookworm (1.1.2+git20200823-1) ... File "/usr/share/com.github.babluboy.bookworm/scripts/mobi_lib/mobiml2xhtml.py", line 507 print 'Converting Mobi Markup Language to XHTML' ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print('Converting Mobi Markup Language to XHTML')?

this should do the work I did copy what you did on other print on this file

jbicha commented 6 months ago

See also https://salsa.debian.org/debian/bookworm/-/blob/master/debian/patches/0001-More-hotfix-on-python2-print.patch

smCloudInTheSky commented 6 months ago

Sure but it is limited to debian Wouldn't it be better in 2024 to merge this within the project as python2 as been deprecated for a while ? If you want I can improve the PR.