search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

Appstream complains about the image #374

Open Carmina16 opened 1 year ago

Carmina16 commented 1 year ago

https://github.com/babluboy/bookworm/blob/36fc5d4916b0861b8b91800837d182715de0caea/data/com.github.babluboy.bookworm.appdata.xml.in#L18

This image contains a transparent margin that causes a validation error by appstream-util, causing the build to fail. Please crop the image or change the validation mode to validate-relax.

babluboy commented 1 year ago

Thanks for the issue - can I understand where exactly do you see the issue and for which distro are you packaging? I have not compiled bookworm for the latest version of elementary OS but for the last version there was not problem with the transparent margin. If this is Fedora related then we should adopt a way for it to work on both. Where does validate-relax needs to be specified?

Carmina16 commented 1 year ago

Any distro that ships appstream-util 0.8+ should do. Just build bookworm and run appstream-util validate <name of generated appdata.xml> . That code is called in test located at https://github.com/babluboy/bookworm/blob/36fc5d4916b0861b8b91800837d182715de0caea/data/meson.build#L67