search

babluboy / bookworm

A simple ebook reader for Elementary OS
GNU General Public License v3.0
1.32k stars 101 forks source link

You are still running org.gnome.Platform on branch 42, which is end of life. #385

Open ghost opened 1 year ago

ghost commented 1 year ago

The following error is reported when updating flatpak. Info: runtime org.gnome.Platform branch 42 is end-of-life, with reason: The GNOME 42 runtime is no longer supported as of March 21, 2023. Please ask your application developer to migrate to a supported platform. Info: applications using this runtime: com.github.babluboy.bookworm, com.github.mdh34.quickdocs

While this may not be an extreme situation, updating the platform to something more recent is something pretty important. If there is no intent on updating, please add to your readme that the project is abandoned.

This needs to be updated if kept on flathub.

babluboy commented 1 year ago

Thanks for the issue - I have updated the runtime to 44 as per https://github.com/elementary/flatpak-platform/blob/main/io.elementary.Sdk.json.in

PR: https://github.com/flathub/com.github.babluboy.bookworm/pull/21

Lets see if the build passes

ghost commented 1 year ago

Thank you! Greatly appreciate the change!

babluboy commented 1 year ago

Unfortunately the build failed : https://buildbot.flathub.org/#/builders/6/builds/51993

reason for failure was: ModuleNotFoundError: No module named 'giscanner._giscanner' when building the poppler library for handling PDFs. Looks like I have to find an alternative to poppler for PDF or drop PDF support from Bookworm. This is the same reason why I am not able to publish Bookworm to the Elementary OS AppStore

ghost commented 1 year ago

If you drop pdf support, that would be okay. Although, I do know of many people who download material in that format and would like it in the same place. But at the end of the day, this is your decision to make.

SpookedByRoaches commented 10 months ago

I've tried to change the versions of the packages and got it to compile, you have to use python 3.10+ to have the giscanner package, and webkit4.1 for some other package. Doing these upgrades would mean that the Soup library version is 3.0 instead of 2.4 which changes the uri decoding API. I've tried to change the usage of those API calls to as close as I could but I kept getting runtime errors. If you want I can make a PR with the changes and you can maybe solve the runtime errors.

babluboy commented 7 months ago

I need to upgrade to the latest version of webkit and i'm also thinking of dropping the support for PDF if girscanner will not work with latest version of gnome and webkit. Hopefully Soup Lib will work with both of those. Let me knw if you have any thoughts.