search

baboons / homebridge-electrolux-wellbeing

Homebridge plugin for Electrolux Pure A9
Apache License 2.0
15 stars 12 forks source link

Fixes and improvements #11

Closed mafredri closed 3 years ago

mafredri commented 3 years ago

Hi, and thanks for creating this plugin!

It worked fine at first but ran into some issues and started fixing one thing and another, ended up with this behemoth of a PR.

Let me know if you want me to split it up and I'll do separate PRs, the commits are bite-sized though.

PS. Do let me know if I've made some wrong assumptions or not considered previous use-cases. For instance, my Pure A9 purifiers fan speed go from 1 - 9, but the max was set at 8, perhaps this is for another model?

baboons commented 3 years ago

Hi, and thanks for creating this plugin!

It worked fine at first but ran into some issues and started fixing one thing and another, ended up with this behemoth of a PR.

Let me know if you want me to split it up and I'll do separate PRs, the commits are bite-sized though.

PS. Do let me know if I've made some wrong assumptions or not considered previous use-cases. For instance, my Pure A9 purifiers fan speed go from 1 - 9, but the max was set at 8, perhaps this is for another model?

  • Enable fan speeds from [1, 9]
  • Show FirmwareRevision in HomeKit
  • Fix log statements, include name
  • Convert TVOC ppb to μg/m3 used by HAP
  • Add value-guard to set child lock and ionizer
  • Generate Wellbeing API type definitions
  • Only set envLightLevel if returned by API

Thanks for the contribution! I think the fanspeed was simply a typo as I do have the A9. I had a quick look ok your PR and I think it's alright brother. Again thanks for the contribution.